Update check-answers.html - #1071
Conversation
Content tweaks to reflect new service name from submit to provide
WalkthroughThis change updates the wording in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File CoverageNo changed files found. |
GitHub Actions
Failure
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/views/submit/check-answers.html (4)
28-30: Improve heading phrasing and keep service-name consistent“Check your answers before providing your dataset” reads a little awkwardly; GOV.UK style tends to prefer the construction “before you provide”.
While touching this block, also consider aligning the service-name with the heading by changing the earlierserviceTypevalue from “Submit” to “Provide” for consistency across analytics, breadcrumbs, etc.- Check your answers before providing your dataset + Check your answers before you provide your dataset
139-141: Minor wording tweak for clarity“Now provide your dataset” is succinct, but GOV.UK headings usually start with a verb followed by the object: “Provide your dataset now” or simply “Provide your dataset”.
Consider the shorter variant for better scannability.- Now provide your dataset + Provide your dataset
143-145: Reduce repetition in the confirmation sentenceThe sentence repeats “providing / provide” twice. A lighter construction keeps the same meaning:
- By providing this dataset you are confirming that, to the best of your knowledge, the details you are providing are correct. + By providing this dataset, you confirm that, to the best of your knowledge, the details are correct.
149-152: Button label could be more explicit“Accept and provide” may be unclear to users unfamiliar with the new terminology. A more explicit action such as “Provide dataset” mirrors the heading and avoids ambiguity.
- text: "Accept and provide", + text: "Provide dataset",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/views/submit/check-answers.html(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
src/views/submit/check-answers.html (1)
Learnt from: DilwoarH
PR: digital-land/submit#1043
File: src/controllers/issueDetailsController.js:83-88
Timestamp: 2025-06-30T22:12:04.103Z
Learning: The datasette service in digital-land/submit only accepts string queries, not parameterized queries with text/values objects. SQL interpolation with trusted data sources is the accepted pattern.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test
- GitHub Check: run-tests / test
2 participants
Content tweaks to reflect new service name from submit to provide
Description
Content tweaks to reflect new service name from submit to provide
What type of PR is this? (check all applicable)
Related Tickets & Documents
#1013
QA Instructions, Screenshots, Recordings
Before
Before screenshot here
After
After screenshot here
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit